Skip to content

Wrap references to public types in comments in double backticks #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 25, 2023

This makes the types show up as links in the generated docc documentation

@ahoppen ahoppen requested a review from bnbarham May 25, 2023 03:13
@ahoppen ahoppen requested a review from DougGregor as a code owner May 25, 2023 03:13
@ahoppen
Copy link
Member Author

ahoppen commented May 25, 2023

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/backticks branch from d7bf438 to 158ffaf Compare May 25, 2023 15:37
@ahoppen
Copy link
Member Author

ahoppen commented May 25, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 25, 2023

@swift-ci Please test Windows

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to be honest, I didn't look through all these. Conceptually okay though :)

@ahoppen ahoppen force-pushed the ahoppen/backticks branch from 158ffaf to 4277bbd Compare May 25, 2023 21:15
@ahoppen
Copy link
Member Author

ahoppen commented May 25, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 26, 2023

@swift-ci Please test macOS

@ahoppen
Copy link
Member Author

ahoppen commented May 26, 2023

@swift-ci Please test Windows

This makes the types show up as links in the generated docc documentation
@ahoppen ahoppen force-pushed the ahoppen/backticks branch from 4277bbd to b357e65 Compare June 1, 2023 18:37
@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge June 1, 2023 18:37
@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 6d65e39 into swiftlang:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants